[AVR] Fix for issue #163015, occasional corruption in stack passed params #164001
+81
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #163015 |
…register pressure. See this forum discussion for details (or the GitHub issue) https://discourse.llvm.org/t/avr-register-allocation-issue-help-advice-with-debugging/88498/11 @aykevl @benshi001
carlos4242
force-pushed
the
fix-163082
branch
from
64b7aad to
aa54b9a
Compare
mshockwave
reviewed
Oct 17, 2025
There was a problem hiding this comment.
please use update_llc_test_checks.py to generate CHECK lines. Also, is there any reason you need -v -dump-input always?
There was a problem hiding this comment.
I think it is not needed to run update_llc_test_checks.py, since the key check point in this test are the CHECK-NOT lines.
There was a problem hiding this comment.
It is up to reviewer to mark resolved/unresolved.
@mshockwave Do you have any more concerns for that?
|
previous PR that I accidentally closed: #163082 |
benshi001
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corruption can occur with passing parameters on the stack when under register pressure.
See this forum discussion for details (or the GitHub issue) https://discourse.llvm.org/t/avr-register-allocation-issue-help-advice-with-debugging/88498/11
@aykevl @benshi001